Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #17016: wrong assertion if label is empty and uses BitmapFont #18015

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

dumganhar
Copy link
Contributor

@dumganhar dumganhar commented Dec 10, 2024

Re: #17016

Also reported at https://forum.cocos.org/t/topic/160454/17

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar requested a review from minggo December 10, 2024 01:52
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

⚠️ Package size ⤴ 26 bytes, old: 5441175, new: 5441201

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -61475,12 +61475,12 @@
             protected _nativeObj: _cocos_2d_renderer_native_2d__NativeRenderDrawInfo;
             protected _uint8SharedBuffer: Uint8Array;
             protected _uint16SharedBuffer: Uint16Array;
             protected _uint32SharedBuffer: Uint32Array;
-            protected _render2dBuffer: Float32Array;
+            protected _render2dBuffer: Float32Array | null;
             constructor(nativeDrawInfo?: _cocos_2d_renderer_native_2d__NativeRenderDrawInfo);
             get nativeObj(): _cocos_2d_renderer_native_2d__NativeRenderDrawInfo;
-            get render2dBuffer(): Float32Array;
+            get render2dBuffer(): Float32Array | null;
             clear(): void;
             setAccId(accId: any): void;
             setBufferId(bufferId: any): void;
             setAccAndBuffer(accId: any, bufferId: any): void;

@dumganhar dumganhar changed the base branch from v3.8.6 to v3.8.5 December 10, 2024 02:53
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@AkshayshettyS
Copy link

@dumganhar
Copy link
Contributor Author

@AkshayshettyS Yes, it seems to be the same issue.

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@dumganhar
Copy link
Contributor Author

@minggo minggo merged commit 84790f5 into cocos:v3.8.5 Dec 12, 2024
12 checks passed
@dumganhar dumganhar mentioned this pull request Dec 18, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants