Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix skeleton animation & skin inspect panel display #18016

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

knoxHuang
Copy link
Contributor

@knoxHuang knoxHuang commented Dec 10, 2024

Re: # #18013

Changelog

  • To improve the display of i18n, it was changed to automatically display based on i18n configuration. However, in the editor, attributes with underscores in their names have their visible property set to false by default, which caused animation and skin attributes to not be displayed. Previously, these attributes were visible because @displayName was used, which sets the visible property to true. To fix the issue of attributes not being displayed, it is necessary to add the @visible(true) decorator to make them appear in the property panel.

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@@ -22,7 +22,7 @@
THE SOFTWARE.
*/
import { EDITOR_NOT_IN_PREVIEW, JSB } from 'internal:constants';
import { ccclass, executeInEditMode, help, menu, serializable, type, displayName, override, displayOrder, editable, tooltip } from 'cc.decorator';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete unused decorators

@knoxHuang knoxHuang requested a review from minggo December 10, 2024 03:13
Copy link

✅ Package size is not changed

Interface Check Report

This pull request does not change any public interfaces !

@knoxHuang knoxHuang requested review from bofeng-song and minggo and removed request for minggo December 10, 2024 06:00
@minggo minggo merged commit 6a08103 into cocos:v3.8.5 Dec 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants