Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix runtime web adapter fetch error #18020

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

wuzhiming
Copy link
Contributor

Re: #
When fetching the runtime-web-adapter, there is an issue with the way the runCommand is written, which may cause timing errors and needs to be fixed.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@wuzhiming wuzhiming requested a review from minggo December 10, 2024 08:40
Copy link

✅ Package size is not changed

Interface Check Report

This pull request does not change any public interfaces !

@minggo
Copy link
Contributor

minggo commented Dec 11, 2024

there is an issue with the way the runCommand is written

What's the issue?

@wuzhiming
Copy link
Contributor Author

there is an issue with the way the runCommand is written

What's the issue?
This happened during our Jenkins packaging process. It is likely caused by the upgrade of the Node.js version, which led to changes in the Node.js API. We need to listen to exec.on('close') instead of exec.stdout.on('close').

@minggo minggo merged commit 970e91c into cocos:v3.8.6 Dec 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants