Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep the original behavior, pause animation playback in the editor #18022

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

knoxHuang
Copy link
Contributor

@knoxHuang knoxHuang commented Dec 10, 2024

Re: #

Changelog

  • Previously, the playback of Spine animations was controlled in the update function based on EDITOR_NOT_IN_PREVIEW to determine whether playback was allowed. This approach caused issues with the preview functionality. To resolve this, the playback control has been changed to depend on the paused state. In order to maintain the original behavior, this PR has been added to ensure that animations do not play in the editor environment.

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@knoxHuang knoxHuang requested a review from wuzhiming December 10, 2024 09:39
Copy link

✅ Package size is not changed

Interface Check Report

This pull request does not change any public interfaces !

@wuzhiming wuzhiming requested a review from minggo December 10, 2024 10:20
@wuzhiming
Copy link
Contributor

@minggo this pr needs to be merged into v3.8.5

@minggo
Copy link
Contributor

minggo commented Dec 11, 2024

@knoxHuang please make the tile more clear. What's the issue with spine?

@knoxHuang
Copy link
Contributor Author

@minggo done

@knoxHuang knoxHuang changed the title Fix spine's when playing in the editor keep the original behavior, pause animation playback in the editor Dec 11, 2024
@minggo minggo merged commit a7de5b9 into cocos:v3.8.5 Dec 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants