Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential ANR issues caused by unsafe calls to the ALooper_pollAll interface. #18025

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Fix potential ANR issues caused by unsafe calls to the ALooper_pollAll interface. #18025

merged 4 commits into from
Dec 13, 2024

Conversation

bofeng-song
Copy link
Contributor

@bofeng-song bofeng-song commented Dec 11, 2024 •
edited
Loading

Re: #
#17511
#17841

The response from a Google engineer regarding potential issues with ALooper_pollAll.
image

The description of ALooper_pollAll in NDK 28.:
image

Changelog

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bofeng-song bofeng-song mentioned this pull request Dec 11, 2024
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

⚠️ Package size ⤴ 42 bytes, old: 5441560, new: 5441602

Interface Check Report

This pull request does not change any public interfaces !

@minggo minggo merged commit 20581f1 into cocos:v3.8.6 Dec 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumganhar dumganhar dumganhar approved these changes

@minggo minggo minggo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bofeng-song @minggo @dumganhar