Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that package size check may be wrong if spine cpp code changed but the generated wasm is not merged into external repo. #18032

Merged

Conversation

dumganhar
Copy link
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

…t the generated wasm is not merged into external repo.
@dumganhar dumganhar requested a review from minggo December 13, 2024 01:34
@dumganhar dumganhar marked this pull request as draft December 13, 2024 01:36
Copy link

✅ Package size is not changed

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar dumganhar marked this pull request as ready for review December 13, 2024 02:21
@dumganhar dumganhar merged commit 2a10e0c into cocos:v3.8.5 Dec 13, 2024
12 checks passed
dumganhar added a commit to dumganhar/cocos-engine that referenced this pull request Dec 13, 2024
…t the generated wasm is not merged into external repo. (cocos#18032)
dumganhar added a commit that referenced this pull request Dec 13, 2024
…t the generated wasm is not merged into external repo. (#18032) (#18033)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant