Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3.8.6] Fix pointerEventProcessorList may not be re-sorted. #18046

Merged
merged 5 commits into from
Dec 17, 2024
Merged

[v3.8.6] Fix pointerEventProcessorList may not be re-sorted. #18046

merged 5 commits into from
Dec 17, 2024

Conversation

dumganhar
Copy link
Contributor

This bug was reported at https://forum.cocos.org/t/topic/163982/10

Re: https://github.com/cocos/3d-tasks/issues/18677

Changelog

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

👍 Package size ⤵ -76 bytes, old: 5442440, new: 5442364

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar dumganhar marked this pull request as draft December 17, 2024 04:48
@dumganhar dumganhar marked this pull request as ready for review December 17, 2024 06:33
@dumganhar dumganhar requested a review from minggo December 17, 2024 06:33
dumganhar
dumganhar commented Dec 17, 2024
View reviewed changes
cocos/scene-graph/node.ts
// see PointerEventDispatcher._sortByPriority.
// child.active = true; // child's eventProcessor has already been enabled, eventProcessor.setEnabled(true) will do nothing.
if (eventProcessor.isEnabled === active) {
NodeEventProcessor.callbacksInvoker.emit(DispatcherEventType.MARK_LIST_DIRTY);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's here to fix the bug.

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@minggo minggo merged commit 0738856 into cocos:v3.8.6 Dec 17, 2024
12 checks passed
@github-actions GitHub Actions
Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
ios PASS PASS PASS
mac PASS PASS FAIL particle-2d-position-type-change keyboard-event,particle-2d-normal

@github-actions GitHub Actions
Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL tween-parallel keyboard-event,particle-compare,tween-custom-progress,tween-parallel
android PASS PASS PASS
wechatgame PASS PASS FAIL BuildTimeConstantsTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minggo minggo minggo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dumganhar @minggo