Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.8.6] Optimize code size for sprite-frame.ts #18095

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

dumganhar
Copy link
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar dumganhar marked this pull request as draft December 28, 2024 08:38
Copy link

github-actions bot commented Dec 28, 2024

👍 Package size ⤵ -1472 bytes, old: 5316211, new: 5314739

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -20178,8 +20178,9 @@
              * @param array @zh 用来拷贝的数组。@en The array to be copied from.
              * @returns @zh 数组的副本。@en A new array has the same values as `array`.
              */
             export function copy<T>(array: T[]): T[];
+            export function fillItems<T>(array: T[], ...items: T[]): void;
             /**
              * @example
              * ```
              * import { js } from 'cc';

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@dumganhar dumganhar requested a review from minggo December 30, 2024 02:33
@dumganhar dumganhar marked this pull request as ready for review December 30, 2024 02:59
Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL
ios PASS PASS FAIL
mac PASS PASS PASS

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

@dumganhar dumganhar merged commit cf3b6b0 into cocos:v3.8.6 Dec 30, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants