Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.8.6] Optimize code size for gfx.FormatInfos definition #18096

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

dumganhar
Copy link
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

👍 Package size ⤵ -1672 bytes, old: 5316212, new: 5314540

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar dumganhar requested review from minggo and star-e December 28, 2024 12:51
@minggo
Copy link
Contributor

minggo commented Dec 30, 2024

It looks great. Can i know why it can reduce package size?

@dumganhar
Copy link
Contributor Author

dumganhar commented Dec 30, 2024

  • new FormatInfo is mangled to new AB while createFormatInfo could be mangled to AB, that saves 4 bytes each.
  • Use default arguments in order, that means false, false, false, false don't need to be passed since the default argument values is that.
  • Add createFormatInfo_ASTC_RGBA & createFormatInfo_ASTC_SRGBA helper functions to avoid passing the long name for ASTC_BALABLA.

@dumganhar dumganhar merged commit cc11e62 into cocos:v3.8.6 Dec 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants