[v3.8.6] Strip jsb-utils.ts #18161
Merged
[v3.8.6] Strip jsb-utils.ts #18161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 Package size ⤵ -588 bytes, old: 5270176, new: 5269588Interface Check ReportThis pull request does not change any public interfaces ! |
|
@cocos-robot run test cases |
|
@dumganhar, Please check the result of
Task Details |
|
@dumganhar, Please check the result of
Task Details |
minggo
reviewed
Jan 13, 2025
| import { getUrlWithUuid } from '../asset-manager/helper'; | ||
| import { patch_cc_Asset } from '../../native-binding/decorators'; | ||
| import type { Asset as JsbAsset } from './asset'; | ||
| import type { AssetManager } from '../asset-manager'; | ||
| import { ExtraEventMethods } from '../../core/utils/jsb-utils'; |
There was a problem hiding this comment.
After doing this, we can not make core as a module in future.
There was a problem hiding this comment.
Let's estimate that in the future.
In fact, importing classes from the path is good for treeshaking.
If we export ExtraEventMethods from 'core' and import it from 'core' here, jsb-utils will not be able to be cut by rollup treeshaking.
minggo
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: