Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.8.6] Optimize code size by adding helper functions to get data from pipelineSceneData. #18172

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

dumganhar
Copy link
Contributor

Re: #18056

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

github-actions bot commented Jan 12, 2025

👍 Package size ⤵ -2396 bytes, old: 5245887, new: 5243491

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar dumganhar requested a review from minggo January 13, 2025 02:12
@dumganhar dumganhar marked this pull request as draft January 13, 2025 09:29
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@dumganhar dumganhar marked this pull request as ready for review January 13, 2025 09:54
Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
mac PASS PASS FAIL director-after-draw-test 2d-rendering-in-3d,director-after-draw-test

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL director-after-draw-test 2d-rendering-in-3d,director-after-draw-test

@dumganhar dumganhar merged commit 979670f into cocos:v3.8.6 Jan 14, 2025
12 checks passed
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

cocos-robot pushed a commit to cocos-robot/engine that referenced this pull request Jan 14, 2025
dumganhar pushed a commit that referenced this pull request Jan 14, 2025
Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL dynamic-mesh dynamic-mesh
ios PASS PASS FAIL director-after-draw-test 2d-rendering-in-3d,director-after-draw-test
mac PASS PASS FAIL director-after-draw-test 2d-rendering-in-3d,director-after-draw-test

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL director-after-draw-test 2d-rendering-in-3d,director-after-draw-test
android PASS PASS FAIL director-after-draw-test 2d-rendering-in-3d,director-after-draw-test
wechatgame PASS PASS FAIL dynamic-mesh dynamic-mesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants