Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix different texture object still use the same cached SkeletonData #18410

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

bofeng-song
Copy link
Contributor

@bofeng-song bofeng-song commented Mar 5, 2025

Re: #
#18402

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bofeng-song bofeng-song requested a review from dumganhar March 5, 2025 07:43
Copy link

github-actions bot commented Mar 5, 2025

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001919 bytes 1001919 bytes ✅ 0 bytes
2D All (legacy pipeline) 2409214 bytes 2409295 bytes ⚠️ +81 bytes
2D All (new pipeline) 2496443 bytes 2496524 bytes ⚠️ +81 bytes
(2D + 3D) All 5412978 bytes 5413059 bytes ⚠️ +81 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16920652 bytes 16920733 bytes ⚠️ +81 bytes

Interface Check Report

This pull request does not change any public interfaces !

@dumganhar
Copy link
Contributor

@cocos-robot run test cases

private mergedUUID(): string {
// merge tuxture's id and atlas content
private mergedUUID (): string {
// merge txture's id and atlas content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: txture -> texture

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@dumganhar dumganhar merged commit 1691624 into cocos:v3.8.6 Mar 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants