Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support check compatible for spine's asset #18425

Open
wants to merge 2 commits into
base: v3.8.6
Choose a base branch
from

Conversation

bofeng-song
Copy link
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bofeng-song bofeng-song requested a review from dumganhar March 7, 2025 08:24
Copy link

github-actions bot commented Mar 7, 2025

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1001924 bytes 1001924 bytes ✅ 0 bytes
2D All (legacy pipeline) 2662844 bytes 2662922 bytes ⚠️ +78 bytes
2D All (new pipeline) 2750073 bytes 2750151 bytes ⚠️ +78 bytes
(2D + 3D) All 10003373 bytes 10003451 bytes ⚠️ +78 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16915707 bytes 16915785 bytes ⚠️ +78 bytes

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -54018,8 +54018,10 @@
         /**
          * @internal Since v3.7.2 this is an engine private object.
          */
         export const simpleSpineAssembler: IAssemblerManager;
+        export function isBinarySupported(buffer: Uint8Array): boolean;
+        export function isJsonSupported(json: JSON): boolean;
         export const SPINE_VERSION = "3.8";
     }
     export class HeightField {
         data: Uint16Array;

@dumganhar dumganhar closed this Mar 9, 2025
@dumganhar dumganhar reopened this Mar 9, 2025
return false;
}

export function isJsonSupported (json: JSON): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some comments for these two methods since they're only avaiable in editor.

And how about rename the method to isBinaryCompatible | isJsonCompatible ?

@dumganhar dumganhar closed this Mar 10, 2025
@dumganhar dumganhar reopened this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants