django-allauth support for obtaining google access-token #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad-m
requested changes
Aug 30, 2020
| @@ -17,37 +20,45 @@ class RefreshTokenNotFound(Exception): | |||
|
|
|||
|
|
|||
| def get_google_consumer_key(): | |||
| if SocialApp: | |||
There was a problem hiding this comment.
I believe this should be a configuration option as using django-allauth and django-guardian in one application doesn't necessarily mean that django-allauth provides a secret for django-guardian.
pfouque
reviewed
Dec 11, 2023
| return settings.SOCIAL_AUTH_GOOGLE_OAUTH2_KEY | ||
|
|
||
|
|
||
| def get_google_consumer_secret(): | ||
| if SocialApp: | ||
| app = SocialApp.objects.filter(provider='google').first() |
There was a problem hiding this comment.
Picking the first all auth google account is not deterministic enough if it's used to provide end-user authentication...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.