Fix malformed setting DJANGO_MAILBOX_DEFAULT_CHARSET #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing DJANGO_MAILBOX_default_charset error, it does not detect the settings in django correctly because one part is in lower case. Changed to DJANGO_MAILBOX_DEFAULT_CHARSET.
pfouque
reviewed
Dec 11, 2023
There was a problem hiding this comment.
Firstly, thanks for your contribution!
Unfortunately, we can't do it this way since some folks probably defined their settings with the current settings name...
Please see my suggestion for a retro-compatible solution.
I also noticed this setting is not described in the documentation... It would be awesome if you could add it in this PR.
Thanks!
pfouque
changed the title
pfouque
approved these changes
Dec 17, 2023
There was a problem hiding this comment.
LGTM, Thanks for your contribution @Robersillo!
I will merge it (but I don't know when the next release will happen)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing DJANGO_MAILBOX_default_charset error, it does not detect the settings in django correctly because one part is in lower case. Changed to DJANGO_MAILBOX_DEFAULT_CHARSET.