-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MessageAttachment __str__ change #283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Pietro395,
it's not clear how / why we can have an attachment without the message it relates to,
but the str should display more about itself than its parent IMO.
I added a suggestion
Co-authored-by: Pascal Fouque <[email protected]>
Hi @pfouque , you are right. |
LGTM @pfouque |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Small change to MessageAttachment str method.
Previously, this exception occurred when "Saving and continue edit" a Message by deleting an attachment