Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back google-apis-core for code-dot-org compatibility #9

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

cat5inthecradle
Copy link
Contributor

As part of the 0.2.1 upgrade (#7), I also updated and pinned google-apis-core to the latest version, 0.15.1. This has a dependency of googleauth 1.9. However, over in the code-dot-org repository where we use this gem, we also use the old google_drive gem which requires googleauth < 1.0

This PR creates version 0.2.2 and rolls google-apis-core back to 0.11.3, the most recent version compatible with googleauth < 1.0

@cat5inthecradle cat5inthecradle requested a review from a team December 11, 2024 20:53
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Confirmed that all dependencies resolve as desired when installing directly from github:

diff --git a/Gemfile b/Gemfile
index 71e3b1354b2..0dd8e59df9e 100644
--- a/Gemfile
+++ b/Gemfile
@@ -63,7 +63,7 @@ gem 'rack-mini-profiler'
 
 group :development do
   gem 'annotate', '~> 3.1.1'
-  gem 'aws-google', '~> 0.2.0'
+  gem 'aws-google', git: 'https://github.com/code-dot-org/aws-google', branch: 'darin/rollback-google-apis-core'
   gem 'web-console', '~> 4.2.0'
   # Bootsnap pre-caches Ruby require paths + bytecode and speeds up boot time significantly.
   # We only use it in development atm to get a feel for it, and the benefit is greatest here.

@cat5inthecradle cat5inthecradle merged commit 1da3606 into main Dec 11, 2024
2 checks passed
@cat5inthecradle
Copy link
Contributor Author

❯ bundle exec rake release
aws-google 0.2.2 built to pkg/aws-google-0.2.2.gem.
Tagged v0.2.2.
Pushed git commits and release tag.
Pushing gem to https://rubygems.org...
You have enabled multi-factor authentication. Please enter OTP code.
Code:   XXXXXX
Successfully registered gem: aws-google (0.2.2)
Pushed aws-google 0.2.2 to https://rubygems.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants