Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update Alpha Setting for Color" #557

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

epeach
Copy link
Contributor

@epeach epeach commented Jan 21, 2019

Reverts #547

Turns out this slightly changes the rainbow backgrounds, but not enough to trigger pixelmatch.
Reverting (to a less elegant, but still working, code) to re-implement without side-effects.

@epeach epeach requested review from joshlory and ajpal January 21, 2019 19:18
@codecov-io
Copy link

Codecov Report

Merging #557 into master will decrease coverage by 0.03%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
- Coverage    34.5%   34.47%   -0.04%     
==========================================
  Files          23       23              
  Lines        3426     3429       +3     
==========================================
  Hits         1182     1182              
- Misses       2244     2247       +3
Impacted Files Coverage Δ
src/Effects.js 40.2% <44.44%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc61be...49a9f74. Read the comment docs.

Copy link
Contributor

@joshlory joshlory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to revert while investigating a fix!

@epeach epeach merged commit ac89774 into master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants