Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable text support #50

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Clickable text support #50

merged 3 commits into from
Jan 23, 2024

Conversation

breville
Copy link
Member

This adds support for clickable text.

When the text markdown contains:

[text](#clickable=id)

This code will generate:

<b data-id="id" class="clickable-text">text</b>

The main repo will make use of this functionality in code-dot-org/code-dot-org#55861.

Copy link
Collaborator

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Couple minor suggestions for improvement, but nothing blocking. And it always makes me happy to see initial implementations get follow-ups like this, thank you for the extra effort!

src/clickableText.js Outdated Show resolved Hide resolved
src/clickableText.js Outdated Show resolved Hide resolved
test/clickableText.test.js Show resolved Hide resolved
@breville breville merged commit 2b56b52 into master Jan 23, 2024
1 check passed
@breville breville deleted the clickable-text-support branch January 23, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants