Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony v7 support #71

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Symfony v7 support #71

merged 1 commit into from
Feb 12, 2025

Conversation

mtvbrianking
Copy link
Contributor

#70

@williamdes
Copy link
Member

PHP Fatal error: Declaration of Doctum\Console\Application::getLongVersion() must be compatible with Symfony\Component\Console\Application::getLongVersion(): string in /home/runner/work/doctum/doctum/src/Console/Application.php on line 40

Well, this is quite an issue. I will see how to workaround it

@mtvbrianking
Copy link
Contributor Author

@williamdes I wanted to bring the phpparser issue to your attention as well

php doctum.phar update doctum.php

PHP Fatal error:  Uncaught Error: Call to undefined method PhpParser\ParserFactory::create() in phar:///.../doctum.phar/src/Doctum.php:526
Stack trace:
#0 phar:///.../doctum.phar/src/Doctum.php(349): Doctum\Doctum->getPhpParser()
#1 phar:///.../doctum.phar/src/Doctum.php(516): Doctum\Doctum->offsetGet()
#2 phar:///.../doctum.phar/src/Doctum.php(343): Doctum\Doctum->getCodeParser()
#3 phar:///.../doctum.phar/src/Doctum.php(481): Doctum\Doctum->offsetGet()
#4 phar:///.../doctum.phar/src/Doctum.php(322): Doctum\Doctum->getParser()
#5 phar:///.../doctum.phar/src/Doctum.php(429): Doctum\Doctum->offsetGet()
#6 phar:///.../doctum.phar/src/Doctum.php(304): Doctum\Doctum->getBuiltProject()
#7 phar:///.../doctum.phar/src/Doctum.php(257): Doctum\Doctum->offsetGet()
#8 phar:///.../doctum.phar/src/Console/Command/UpdateCommand.php(58): Doctum\Doctum->getProject()
#9 phar:///.../doctum.phar/vendor/symfony/console/Command/Command.php(298): Doctum\Console\Command\UpdateCommand->execute()
#10 phar:///.../doctum.phar/vendor/symfony/console/Application.php(1040): Symfony\Component\Console\Command\Command->run()
#11 phar:///.../doctum.phar/vendor/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand()
#12 phar:///.../doctum.phar/vendor/symfony/console/Application.php(171): Symfony\Component\Console\Application->doRun()
#13 phar:///.../doctum.phar/bin/doctum-binary.php(26): Symfony\Component\Console\Application->run()
#14 /.../doctum.phar(16): include('...')
#15 {main}
thrown in phar:///.../doctum.phar/src/Doctum.php on line 526

You might need to support phpparser v5 because most packages require only v5 leading to conflicts

- "nikic/php-parser": "^4.10",
+ "nikic/php-parser": "^4.1|^5.0",

@williamdes
Copy link
Member

Indeed, sorry for the delay
Ref: #72

@williamdes williamdes merged commit d127818 into code-lts:main Feb 12, 2025
19 of 35 checks passed
@williamdes williamdes self-assigned this Feb 12, 2025
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@williamdes williamdes added this to the 6.0.0 milestone Feb 12, 2025
@williamdes
Copy link
Member

The next major version will have to drop support for some PHP versions

@williamdes williamdes mentioned this pull request Feb 12, 2025
williamdes added a commit that referenced this pull request Feb 12, 2025
williamdes added a commit that referenced this pull request Feb 12, 2025
@williamdes williamdes modified the milestones: 6.0.0, v5.6.0 Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants