-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat:bounty submission for user and pending bounty list for admin #1091
Feat:bounty submission for user and pending bounty list for admin #1091
Conversation
Here are the videos with better clarity : |
Correct me if I am wrong ser . |
its a place to edit the address details quickly(it can be hidden at first and used mainly to edit the detail or remove some address), we can remove it completely and redirect the user to the
how do you propose we should validate? with just links itll be tricky. maybe we can display the users github along with the link so that admin can check if its the same person who submitted the pr which is the easiest solution. what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nischal-shetty2 linting checks have been failed sir
its related to this #956 , i ran lint:fix and format:fix before committing ser don't worry! |
Added this for easier admin clarification Screen.Recording.2024-09-01.at.11.07.27.PM.mov |
@siinghd @devsargam @hkirat guys check this out |
@nischal-shetty2 I will check this today before eod |
@devsargam ser let me bother you by reminding about this |
@devsargam bhai 🥲 |
@nischal-shetty2 10pm today else again write msg 😄 |
ser reminder @devsargam |
Checking in while sir |
@nischal-shetty2 pls check the above. I will check this later on got some other's to reivew. |
@devsargam the above being? |
The review sir |
U need to add auth in all server actions |
Closing because of inactivity. @nischal-shetty2 it's a great pr. Feel free to reopen. |
@devsargam exams are going on so couldnt do much, will reopen in 1-2 days. ps dont have permission to reopen this, should i just make a new pr? |
got it. All the best for ur exams. Yes, create a new one |
PR Fixes:
Fixes #1090
User:
User-submission.mov
Admin:
Admin-submission.mov
Checklist before requesting a review