Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat:bounty submission for user and pending bounty list for admin #1091

Closed

Conversation

nischal-shetty2
Copy link
Contributor

@nischal-shetty2 nischal-shetty2 commented Aug 31, 2024

PR Fixes:

  • 1 Users can now submit Bounties and check the status of their bounties and the amount they received
  • 2 Admins can see pending bounties and review them and update the amount paid to the user and theyll easily have access to the account addresses of whoever submitted the bounty request,
  • 3 Admins can also view the total amount of bounties disbursed

Fixes #1090

User:

User-submission.mov

Admin:

Admin-submission.mov

Screenshot 2024-08-31 at 2 17 46 PM

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@nischal-shetty2
Copy link
Contributor Author

@amanbairagi30
Copy link
Contributor

  1. Ser , why are you letting users again fill up the payout details at bounty page which is already being done in payout methods right ?

  2. Also when adding the PR link don't you think it must be validated so that users don't end up submitting others PR , which will make admin life hard to validate the user to confirm he/she is the one whose has got that much amount of bounty assigned .

Correct me if I am wrong ser .

@nischal-shetty2
Copy link
Contributor Author

nischal-shetty2 commented Aug 31, 2024

  1. Ser , why are you letting users again fill up the payout details at bounty page which is already being done in payout methods right ?

its a place to edit the address details quickly(it can be hidden at first and used mainly to edit the detail or remove some address), we can remove it completely and redirect the user to the payout method page but i think its redundant although we can put a button which takes them there but its extra steps i believe. unless you have some other idea that can be worked on.(maybe i could combine bounty and payout method page but it would be too cluttered)

Also when adding the PR link don't you think it must be validated so that users don't end up submitting others PR , which will make admin life hard to validate the user to confirm he/she is the one whose has got that much amount of bounty assigned .

how do you propose we should validate? with just links itll be tricky. maybe we can display the users github along with the link so that admin can check if its the same person who submitted the pr which is the easiest solution. what do you think?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nischal-shetty2 linting checks have been failed sir

@nischal-shetty2
Copy link
Contributor Author

@nischal-shetty2 linting checks have been failed sir

its related to this #956 , i ran lint:fix and format:fix before committing ser don't worry!

@nischal-shetty2
Copy link
Contributor Author

Added this for easier admin clarification

Screen.Recording.2024-09-01.at.11.07.27.PM.mov

@nischal-shetty2
Copy link
Contributor Author

@siinghd @devsargam @hkirat guys check this out

@devsargam
Copy link
Collaborator

@nischal-shetty2 I will check this today before eod

@nischal-shetty2
Copy link
Contributor Author

@devsargam ser let me bother you by reminding about this

@nischal-shetty2
Copy link
Contributor Author

@devsargam bhai 🥲

@devsargam
Copy link
Collaborator

@nischal-shetty2 10pm today else again write msg 😄

@nischal-shetty2
Copy link
Contributor Author

@nischal-shetty2 10pm today else again write msg 😄

ser reminder @devsargam

@devsargam
Copy link
Collaborator

Checking in while sir

@devsargam
Copy link
Collaborator

@nischal-shetty2 pls check the above. I will check this later on got some other's to reivew.

@nischal-shetty2
Copy link
Contributor Author

@nischal-shetty2 pls check the above. I will check this later on got some other's to reivew.

@devsargam the above being?

@devsargam
Copy link
Collaborator

The review sir

@devsargam
Copy link
Collaborator

U need to add auth in all server actions

@devsargam
Copy link
Collaborator

Closing because of inactivity. @nischal-shetty2 it's a great pr. Feel free to reopen.

@devsargam devsargam closed this Sep 24, 2024
@nischal-shetty2
Copy link
Contributor Author

nischal-shetty2 commented Sep 24, 2024

@devsargam exams are going on so couldnt do much, will reopen in 1-2 days.

ps dont have permission to reopen this, should i just make a new pr?

@devsargam
Copy link
Collaborator

got it. All the best for ur exams. Yes, create a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: No way to submit bounties and track disbursed bounties
3 participants