Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure captions settings are visible on dark as well as light mode #1565

Closed

Conversation

MNZ02
Copy link
Contributor

@MNZ02 MNZ02 commented Nov 12, 2024

PR Fixes:

  • 1 Fixed captions settings visibility in light mode
  • 2 Adjusted background color

Resolves #1549

Screenshots

Screenshot from 2024-11-13 00-42-09
Screenshot from 2024-11-13 00-42-15

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I assure there is no similar/duplicate pull request regarding same issue.
  • I have tested the changes on multiple screen sizes to verify the fix.

@MNZ02
Copy link
Contributor Author

MNZ02 commented Nov 12, 2024

@devsargam can you please explain why checks are failing, even though I have made changes to only one file? Also how could I correct this? Running prettier --write formats a lot of components but I do not want to push those components as they are not related to this fix.

@devsargam
Copy link
Collaborator

It's the lint issue sir

@devsargam
Copy link
Collaborator

As said in issue

@devsargam devsargam closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: dropdowns and options are not visible for captions settings
2 participants