Add a YouTube video renderer component #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @hkirat , Could you please take a look and provide your feedback? |
|
This needs to be integrated to VideoPlayer.js |
hkirat
reviewed
Apr 16, 2024
| // video_1080p_4: 'https://www.w3schools.com/html/mov_bbb.mp4', | ||
| // video_720p_mp4_1: 'https://www.w3schools.com/html/mov_bbb.mp4', | ||
| // video_720p_mp4_2: 'https://www.w3schools.com/html/mov_bbb.mp4', | ||
| // video_720p_mp4_3: 'https://www.w3schools.com/html/mov_bbb.mp4', |
There was a problem hiding this comment.
The purpose of this modification was to integrate support for YouTube video URLs within the component. Meanwhile, for the main application, links sourced from the database or other provided sources will remain functional.
There was a problem hiding this comment.
@hkirat, while the linting and formatting for the code pushed to this branch appear to be correct, it seems that the workflow is failing. Could you please investigate and address this issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes:
Resolves #435
Checklist before requesting a review