Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Static Site Generation (SSG) for all pages #457

Closed
wants to merge 2 commits into from

Conversation

mvp5464
Copy link
Contributor

@mvp5464 mvp5464 commented Apr 17, 2024

PR Fixes:

  • 1 Now all pages will be generated during build time
  • 2 It will avoid fetching of the same data

Resolves #455

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

Screenshot1

@mvp5464 mvp5464 marked this pull request as draft April 18, 2024 11:25
@mvp5464 mvp5464 marked this pull request as ready for review April 18, 2024 14:44
@mvp5464
Copy link
Contributor Author

mvp5464 commented Apr 24, 2024

@hkirat Sir , should I add on demand revalidate, when adding new content ( so when clicking on button to add new content it will revalidate at that time (almost completed locally) . or any other change is needed in this pr

@siinghd
Copy link
Collaborator

siinghd commented Jun 30, 2024

@mvp5464 revalidate is needed, also solve the conflicts

@mvp5464 mvp5464 marked this pull request as draft July 10, 2024 07:47
@mvp5464
Copy link
Contributor Author

mvp5464 commented Jul 11, 2024

@siinghd , here both the page.tsx are server component and they are using searchParams, which is dynamical API, which is not compatible with generateStaticParam(). so either we need to remove searchParams or convert the page into client component. Or guide me if I'm missing something.
vercel/next.js#49735

@mvp5464 mvp5464 closed this Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Static Site Generation (SSG) for all pages
2 participants