Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: Seed video duration to the database without JSON #486

Closed
wants to merge 6 commits into from

Conversation

mvp5464
Copy link
Contributor

@mvp5464 mvp5464 commented Apr 23, 2024

PR Fixes:

  • 1 If video duration is empty, and anyone clicks on that video, It adds video duration to the database
  • 2 Video thumbnail will have proper duration

Resolves #485

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue
Screencast.from.23-04-24.01.51.18.PM.IST.webm

@mvp5464
Copy link
Contributor Author

mvp5464 commented Apr 23, 2024

@hkirat sir, tried many methods (like seeding all videos in SSG, etc.) to seed duration, but this seems good. After old video duration is seeded then we can add duration when you upload the video, if needed (working on it).

  • any suggestion or improvement sir.

@mvp5464 mvp5464 changed the title fixed: Seed video duration to the database fixed: Seed video duration to the database without JSON Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Show video duration to the thumbnail instead of 0
1 participant