refactor: certificate ui & add completedAt field #613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Since we are generating certificate of type PDF ( using pdf-lib ) & PNG ( using HTMLCanvas api ) both have few standard fonts exposed for use. Either we can have a cursive font on PNG certificate but not on PDF which is inconsistent.
So in this PR I've used an overlapping web-safe font exposed by both of them i.e. Courier
Using a external font locally is causing loader(webpack config) issues.
completedAtfield of type Date in the schema and lastly used legit signature on the cert(photoshop) ;)Resolves #596
Checklist before requesting a review