Feature/course form fixed #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pruthviraj7714 whats wrong with 10K+ add? can you update pnpm-lock from main? |
|
@siinghd Done |
siinghd
requested changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes:
Checklist before requesting a review
Modified the course add form and used shadcn form with the toaster component and error messages for form validation
before: there is no proper error handling showing and redirection also no validation of course added or not
https://github.com/code100x/cms/assets/138095461/ca5a15db-3360-4c1b-a079-692d6ab72c2c
after:
https://github.com/code100x/cms/assets/138095461/05a3b3a1-0f14-472f-8989-72205348405f