-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add email domain suggestions to signin component #848
Conversation
Hey @hkirat , The code changes are in accordance with the requirements specified in #841 (comment). |
@vijaysingh2219 will check this and get back |
Hey @siinghd , here is a demo showcasing how the feature works. demo.mp4 |
very nice PR |
Checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly locally
Kapture.2024-08-09.at.20.43.07.mp4
Thank you! @hkirat , I appreciate the feedback. |
@devsargam , do you have the permissions to merge this PR? |
I do not. Waiting for hkirat or hsingh to merge it. 👌 |
Hey @hkirat , can you merge this PR? It has been reviewed by @devsargam . |
hey @vijaysingh2219 did u add anything else since I reviewed this pr? |
Hey @devsargam , no additional changes since your review. Everything was perfect as is. |
ok @vijaysingh2219 this pr will be merged soon. I will check with the guys |
Thanks! Sounds good, just let me know if anything else is needed from my side. |
@vijaysingh2219 can you fix locks files? |
Done! The lock files have been fixed. Let me know if there's anything else you need. |
@vijaysingh2219 thank you sir!!! |
Thank you, @devsargam , for merging the PR! I appreciate the review and your help in moving this forward. |
PR Fixes: #843
Resolves #843
Checklist before requesting a review