Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add email domain suggestions to signin component #848

Merged
merged 10 commits into from
Sep 1, 2024
Merged

feat: Add email domain suggestions to signin component #848

merged 10 commits into from
Sep 1, 2024

Conversation

vijaysingh2219
Copy link
Contributor

PR Fixes: #843

Resolves #843

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@vijaysingh2219
Copy link
Contributor Author

Hey @hkirat , The code changes are in accordance with the requirements specified in #841 (comment).

@siinghd
Copy link
Collaborator

siinghd commented Aug 6, 2024

@vijaysingh2219 will check this and get back

@vijaysingh2219
Copy link
Contributor Author

Hey @siinghd , here is a demo showcasing how the feature works.

demo.mp4

@hkirat
Copy link
Contributor

hkirat commented Aug 9, 2024

very nice PR
@siinghd @devsargam for review

@devsargam
Copy link
Collaborator

Checking

Copy link
Collaborator

@devsargam devsargam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly locally

Kapture.2024-08-09.at.20.43.07.mp4

@vijaysingh2219
Copy link
Contributor Author

very nice PR @siinghd @devsargam for review

Thank you! @hkirat , I appreciate the feedback.

@vijaysingh2219
Copy link
Contributor Author

Works perfectly locally

Kapture.2024-08-09.at.20.43.07.mp4

@devsargam , do you have the permissions to merge this PR?

@devsargam
Copy link
Collaborator

I do not. Waiting for hkirat or hsingh to merge it. 👌

@vijaysingh2219
Copy link
Contributor Author

very nice PR @siinghd @devsargam for review

Hey @hkirat , can you merge this PR? It has been reviewed by @devsargam .

@devsargam
Copy link
Collaborator

hey @vijaysingh2219 did u add anything else since I reviewed this pr?

@vijaysingh2219
Copy link
Contributor Author

hey @vijaysingh2219 did u add anything else since I reviewed this pr?

Hey @devsargam , no additional changes since your review. Everything was perfect as is.

@devsargam
Copy link
Collaborator

ok @vijaysingh2219 this pr will be merged soon. I will check with the guys

@vijaysingh2219
Copy link
Contributor Author

ok @vijaysingh2219 this pr will be merged soon. I will check with the guys

Thanks! Sounds good, just let me know if anything else is needed from my side.

@siinghd
Copy link
Collaborator

siinghd commented Aug 26, 2024

@vijaysingh2219 can you fix locks files?

@vijaysingh2219
Copy link
Contributor Author

@vijaysingh2219 can you fix locks files?

Done! The lock files have been fixed. Let me know if there's anything else you need.

@devsargam
Copy link
Collaborator

hey @siinghd @hkirat can we merge this?

@devsargam devsargam merged commit ff19b43 into code100x:main Sep 1, 2024
1 check failed
@devsargam
Copy link
Collaborator

@vijaysingh2219 thank you sir!!!

@vijaysingh2219
Copy link
Contributor Author

Thank you, @devsargam , for merging the PR! I appreciate the review and your help in moving this forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Enhance Login Page with password Focus and Email Auto-Complete
4 participants