Added script for adding subtitles to videos that already don't have one #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, let me test it |
Yeah let me know if it works as expected or needs some improvement |
|
@Pritam12F Can we optimise it? There is a way in ffmpeg to only download the .mp3 from the videoURL. |
|
And I think our videoJS requires the .srt file for the subtitles. No the JSON format |
|
@SujithThirumalaisamy Will fix this |
|
Tested it locally? |
I don't have access to an OpenAI api key, so I couldn't test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes:
Resolves #875
Script that will take contentId of a video, generate and upload the subtitles to bunny in .json format if it doesn't already have subtitles.
It will download the video, convert it to mp3 and generate a .json file in the temp/ folder which I have added to .gitignore and after the subtitle is successfully uploaded, the temp folder/files inside it will be deleted.
Need an OpenAI api key and some other .env variables I have added in the .env.example file
Checklist before requesting a review