FIX: Cyclic Import #414
Merged
FIX: Cyclic Import #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not clear for now atleast. Feel free to update with the changes. Will be resolving in hotly.
|
Sorry a lot of lint changes. Done it to make it as one whole conflict for everyone. We will not do this again for sure. Wanted to clean this a bit. |
|
Will need to test each and every page for this, let's do this sometime in the day. Whenever you're free, can connect on discord and check every page. |
|
I'll also review it once, if you by chance missed something. Since it's a huge PR. |
|
LGTM @hkirat |
|
/bounty $100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not Clearn.
Fixing it hotly. Please update with change request.
Fixes: #413