Only show install extension item in sidebar if user has matching browser #460
Conversation
GabrielMajeri
requested review from
bvizureanu,
RaduCStefanescu and
surdu
as code owners
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/code4romania/stam-acasa/bwwfrnp3b |
|
|
||
| const SidebarLayout = ({ children }) => { | ||
| // Browser detection based on this answer: | ||
| // https://stackoverflow.com/a/9851769/5723188 | ||
| const isChrome = |
There was a problem hiding this comment.
FYI: this doesn't seem to work on Chrome mobile.
But that should not matter as Chrome mobile doesn't support extensions yet.
The Firefox detection works on mobile, which matter the most
There was a problem hiding this comment.
Yeah, I think the mechanism for detecting Chrome relies on detecting Chrome extension support, so if mobile doesn't have it, it won't show up.
|
I remember seeing a comment from, I want to say @catileptic , where she argued that we want to advertise that we have the extension on any browser, so that the user knows that if he/she uses other web browser than those two, or Internet Explorer, she/he will know about our extensions. ... or something like that |
Yes there was a valid comment on that direction. |
|
It's more probable that if some user visits the site in a browser, it would be the primary browser they use. And if the extension seems useful to them, they could always search for the version for their other browser. |
|
Not if their primary browser, or the browser they have to use at work, is a browser that is not Chrome / Firefox. There might be valid cases where they use Opera, Safari (most Mac users do) or IE, and they see a value installing/using Chrome selectively just to browse the news and have the benefit of our extensions. A good compromise would be to show that we have extensions for Chrome and Firefox, and have a button "Install in your browser" if we detect the user is visiting from a supported browser |
|
@surdu Ok, I've tried out this alternative. This is how it would look. |
|
How will this look on Safari ? I was thinking more like having a generic box mentioning that we have extensions for Chrome / Firefox with links to both of them and the Install button appearing only on supported browsers. @overeha , @catileptic , @RaduCStefanescu any suggestions ? |
What does it fix?
Partially addresses #367 (in order to also display an icon as suggested, we'd need to first modify InstrumentsItem)
The install extension item is only shown for the current browser.
How has it been tested?
Locally tested it with Chromium and Firefox.