Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delete user integration #469

Merged
merged 21 commits into from
Jul 31, 2020

Conversation

idormenco
Copy link
Member

@idormenco idormenco commented Jul 8, 2020

tested manually closes #419 closes #418

@vercel
Copy link

vercel bot commented Jul 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/code4romania/stam-acasa/g6qzsc86r
✅ Preview: https://stam-acasa-git-feature-delete-user-integration.code4romania.vercel.app

@surdu
Copy link
Member

surdu commented Jul 9, 2020

Doesn't this redo work done in #461 ?

surdu
surdu previously requested changes Jul 9, 2020
frontend/src/components/DeleteAccount/index.js Outdated Show resolved Hide resolved
frontend/src/api/accountApi.js Show resolved Hide resolved
@surdu
Copy link
Member

surdu commented Jul 22, 2020

Please run npm run lint:fix

@RaduCStefanescu
Copy link
Contributor

@idormenco can you please run npm run lint:fix so we can merge this one

@idormenco
Copy link
Member Author

idormenco commented Jul 31, 2020

@idormenco can you please run npm run lint:fix so we can merge this one

@RaduCStefanescu
done

@RaduCStefanescu RaduCStefanescu dismissed surdu’s stale review July 31, 2020 13:42

Makes sense to do it like this, but let's keep the email as an input in this iteration.

@RaduCStefanescu RaduCStefanescu merged commit fb9cb29 into develop Jul 31, 2020
@RaduCStefanescu RaduCStefanescu deleted the feature/delete-user-integration branch July 31, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete account view Delete account feature
5 participants