Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worked on Add language switcher #41 #50

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

raresito
Copy link

Added drop-down selector for app language Changed MenuItem to CustomMenuItem as it was overwriting Material-UI component

Added drop-down selector for app language Changed MenuItem to CustomMenuItem as it was overwriting Material-UI component
@raresito
Copy link
Author

screenshot 2019-01-26 at 14 40 14


render() {
const ROstyle = {
background: 'url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEAAAABACAYAAACqaXHeAAAA2ElEQVR4Xu3awQ2DQAxE0aUD+sgtFdAZZdBBCsoxTaQBJJCQSBqYi+VHAdZiz3jtr51G829q/v9DAiigeQZYoLkANEEWYIHmGWCBnwAe65EUw/7akuHGe5mj8Z7fz1X8vwIkgAJYIGkyPUATdAskHeUaNAcYhEyC0Z5iFLYLWIZsg9ZhPAAQQYQgMVD0zgAoCoqCosl1CxQFRUHRpKNAUVAUFAVFoz0FFAVFQVFQFBQFRUFRj6W9FI2OVwWDUUDBokWPTAHRdBYMRgEFixY9MgVE01kwWHsFnD90GFD0ppYyAAAAAElFTkSuQmCC)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S-ar putea pune in fisiere cele 3 constante si importate ulterior. Ar fi cu o idee mai curata clasa. Daca nu, macar importate stringurile dintr-un fisier separat?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raresito could you please implement suggested improvements? :)

@andreiio andreiio removed their request for review April 13, 2019 18:45
Copy link
Contributor

@RaduCStefanescu RaduCStefanescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments on pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants