Replaced href with Router link #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamalexandru4
requested review from
aniri,
catileptic,
moonflare,
RaduCStefanescu,
RazvanCiuca,
surdu,
tudoramariei and
Utwo
as code owners
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/code4romania/taskforce-fe-components/2w9tg0dl7 |
Utwo
requested changes
Oct 5, 2020
| @@ -9,6 +9,7 @@ | |||
| "echarts": "^4.8.0", | |||
| "echarts-for-react": "^2.0.16", | |||
| "react-datepicker": "^3.1.3", | |||
| "react-router-dom": "^5.2.0", | |||
There was a problem hiding this comment.
We should have this as a peerDependencie
surdu
approved these changes
Oct 11, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#181 Solved the issue. I hope that I understood correctly the request.
Replaced the "" tag with react-router functionality "".
Changed also the example in StoryBook.