for issue facebookarchive#41 and facebookarchive#39

the torch7 had Add a keepdim parameter for reduction functions over a single dimension.For detail torch/torch7@c5e5487 so that commit make thpp can't compile.
codeVerySlow · May 26, 2017 · d9f982c · d9f982c
1 parent 899817d
commit d9f982c
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/thpp/detail/TensorGeneric.h b/thpp/detail/TensorGeneric.h
@@ -188,17 +188,17 @@ template <> struct TensorOps<Tensor<real>> {
   }
   static void _max(THTensor* values, THLongTensor* indices,
                    THTensor* t, int dim) {
-    return THTensor_(max)(values, indices, t, dim);
+    return THTensor_(max)(values, indices, t, dim, 1);
   }
   static void _min(THTensor* values, THLongTensor* indices,
                    THTensor* t, int dim) {
-    return THTensor_(min)(values, indices, t, dim);
+    return THTensor_(min)(values, indices, t, dim, 1);
   }
   static void _sum(THTensor* r, THTensor* t, int dim) {
-    return THTensor_(sum)(r, t, dim);
+    return THTensor_(sum)(r, t, dim, 1);
   }
   static void _prod(THTensor* r, THTensor* t, int dim) {
-    return THTensor_(prod)(r, t, dim);
+    return THTensor_(prod)(r, t, dim, 1);
   }
   static void _cumsum(THTensor* r, THTensor* t, int dim) {
     return THTensor_(cumsum)(r, t, dim);