Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module github.com/knadh/koanf to v2 #356

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Apr 12, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/knadh/koanf require major v1.5.0 -> v2.0.1

Release Notes

knadh/koanf

v2.0.1

Compare Source

v2.0.0

Compare Source

This is a major breaking change that ends koanf v1 (v1.5.0) and moves to v2. Continued usage of v1 is unaffected. While koanf does not bundle external dependencies into its core thereby avoiding them in the build, a go get would still pull them and go.mod, bringing in unnecessary references as all the providers and parsers were "sub" packages of the main module.

This PR upgrades koanf to v2 and separates every single provider and parser package into its own module with its own go.mod and its own release tag (eg: providers/yaml/v0.1.0`). That is, one-repository, many modules. This removes references to all indirect dependencies in the main koanf package significantly de-cluttering it.

What changes?
  • Going forward, koanf references should change to github.com/knadh/koanf/v2.
  • The required parsers and providers should be installed explicitly as they do not come bundled with the main koanf package anymore. Eg: go get github.com/knadh/koanf/providers/s3, go get github.com/knadh/koanf/parsers/json etc.
  • That's all. There is no change in functionality.

Full Changelog: knadh/koanf@v1.5.0...v2.0.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Apr 12, 2023
@renovate
Copy link
Author

renovate bot commented Apr 12, 2023

⚠ Artifact update problem

Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: confmap/go.sum
Command failed: docker run --rm --name=renovate_sidecar --label=renovate_child -v "/mnt/renovate/gh/codeboten/opentelemetry-collector":"/mnt/renovate/gh/codeboten/opentelemetry-collector" -v "/tmp/renovate-cache":"/tmp/renovate-cache" -v "/tmp/containerbase":"/tmp/containerbase" -e GOPATH -e GOPROXY -e GOFLAGS -e CGO_ENABLED -e GIT_CONFIG_KEY_0 -e GIT_CONFIG_VALUE_0 -e GIT_CONFIG_KEY_1 -e GIT_CONFIG_VALUE_1 -e GIT_CONFIG_KEY_2 -e GIT_CONFIG_VALUE_2 -e GIT_CONFIG_COUNT -e BUILDPACK_CACHE_DIR -e CONTAINERBASE_CACHE_DIR -w "/mnt/renovate/gh/codeboten/opentelemetry-collector/confmap" ghcr.io/containerbase/sidecar bash -l -c "install-tool golang 1.20.3 && go get -d -t ./..."
go: downloading github.com/knadh/koanf/maps v0.1.1
go: downloading github.com/knadh/koanf/providers/confmap v0.1.0
go.opentelemetry.io/collector/confmap imports
	github.com/knadh/koanf/maps: ambiguous import: found package github.com/knadh/koanf/maps in multiple modules:
	github.com/knadh/koanf v1.5.0 (/tmp/renovate-cache/others/go/pkg/mod/github.com/knadh/[email protected]/maps)
	github.com/knadh/koanf/maps v0.1.1 (/tmp/renovate-cache/others/go/pkg/mod/github.com/knadh/koanf/[email protected])
go.opentelemetry.io/collector/confmap imports
	github.com/knadh/koanf/providers/confmap: ambiguous import: found package github.com/knadh/koanf/providers/confmap in multiple modules:
	github.com/knadh/koanf v1.5.0 (/tmp/renovate-cache/others/go/pkg/mod/github.com/knadh/[email protected]/providers/confmap)
	github.com/knadh/koanf/providers/confmap v0.1.0 (/tmp/renovate-cache/others/go/pkg/mod/github.com/knadh/koanf/providers/[email protected])

File name: cmd/builder/go.sum
Command failed: docker run --rm --name=renovate_sidecar --label=renovate_child -v "/mnt/renovate/gh/codeboten/opentelemetry-collector":"/mnt/renovate/gh/codeboten/opentelemetry-collector" -v "/tmp/renovate-cache":"/tmp/renovate-cache" -v "/tmp/containerbase":"/tmp/containerbase" -e GOPATH -e GOPROXY -e GOFLAGS -e CGO_ENABLED -e GIT_CONFIG_KEY_0 -e GIT_CONFIG_VALUE_0 -e GIT_CONFIG_KEY_1 -e GIT_CONFIG_VALUE_1 -e GIT_CONFIG_KEY_2 -e GIT_CONFIG_VALUE_2 -e GIT_CONFIG_COUNT -e BUILDPACK_CACHE_DIR -e CONTAINERBASE_CACHE_DIR -w "/mnt/renovate/gh/codeboten/opentelemetry-collector/cmd/builder" ghcr.io/containerbase/sidecar bash -l -c "install-tool golang 1.20.3 && go get -d -t ./..."
go: downloading github.com/knadh/koanf/parsers/yaml v0.1.0
go: downloading github.com/knadh/koanf/providers/env v0.1.0
go: downloading github.com/knadh/koanf/providers/file v0.1.0
go: downloading github.com/knadh/koanf/providers/fs v0.1.0
go.opentelemetry.io/collector/cmd/builder/internal imports
	github.com/knadh/koanf/parsers/yaml: ambiguous import: found package github.com/knadh/koanf/parsers/yaml in multiple modules:
	github.com/knadh/koanf v1.5.0 (/tmp/renovate-cache/others/go/pkg/mod/github.com/knadh/[email protected]/parsers/yaml)
	github.com/knadh/koanf/parsers/yaml v0.1.0 (/tmp/renovate-cache/others/go/pkg/mod/github.com/knadh/koanf/parsers/[email protected])
go.opentelemetry.io/collector/cmd/builder/internal imports
	github.com/knadh/koanf/providers/env: ambiguous import: found package github.com/knadh/koanf/providers/env in multiple modules:
	github.com/knadh/koanf v1.5.0 (/tmp/renovate-cache/others/go/pkg/mod/github.com/knadh/[email protected]/providers/env)
	github.com/knadh/koanf/providers/env v0.1.0 (/tmp/renovate-cache/others/go/pkg/mod/github.com/knadh/koanf/providers/[email protected])
go.opentelemetry.io/collector/cmd/builder/internal imports
	github.com/knadh/koanf/providers/file: ambiguous import: found package github.com/knadh/koanf/providers/file in multiple modules:
	github.com/knadh/koanf v1.5.0 (/tmp/renovate-cache/others/go/pkg/mod/github.com/knadh/[email protected]/providers/file)
	github.com/knadh/koanf/providers/file v0.1.0 (/tmp/renovate-cache/others/go/pkg/mod/github.com/knadh/koanf/providers/[email protected])
go.opentelemetry.io/collector/cmd/builder/internal/config imports
	github.com/knadh/koanf/providers/fs: ambiguous import: found package github.com/knadh/koanf/providers/fs in multiple modules:
	github.com/knadh/koanf v1.5.0 (/tmp/renovate-cache/others/go/pkg/mod/github.com/knadh/[email protected]/providers/fs)
	github.com/knadh/koanf/providers/fs v0.1.0 (/tmp/renovate-cache/others/go/pkg/mod/github.com/knadh/koanf/providers/[email protected])

@codeboten codeboten closed this Apr 12, 2023
@renovate
Copy link
Author

renovate bot commented Apr 12, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 2.x releases. But if you manually upgrade to 2.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/github.com-knadh-koanf-2.x branch April 12, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant