fix cronjob bug #20
Closed
fix cronjob bug #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grieshaber
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Thanks for your PR @mbaykara and sorry for the super late response.
I asked for a small change and then will merge it asap :)
| @@ -5,6 +5,7 @@ | |||
| {{- $pullPolicy := .Values.cronJob.image.pullPolicy -}} | |||
| {{- $failedJobsHistoryLimit := .Values.cronJob.failedJobsHistoryLimit -}} | |||
| {{- $successfulJobsHistoryLimit := .Values.cronJob.successfulJobsHistoryLimit -}} | |||
| {{- $global := . }} | |||
There was a problem hiding this comment.
I think there is no need for that Mapping - you can always just use $.Values to access the root values.
|
Resolved with #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In environments that have implemented taints and tolerations, it is crucial to define tolerations for cronjobs as well; otherwise, the spiked pods will remain in a "pending" status.