Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Keycloak JDK UseContainerSupport parameter #744

Conversation

megian
Copy link
Contributor

@megian megian commented Jan 24, 2024

The parameter -XX:+UseContainerSupport is no longer required for Keycloak >= v21 based on JDK v17. JDK >= v17 has enabled the container support by default.

@megian megian requested a review from a team as a code owner January 24, 2024 15:53
@megian megian force-pushed the remove-keycloak-jdk-use-container-support branch from 216fe0a to ed47893 Compare February 23, 2024 16:49
@github-actions github-actions bot removed the Keycloak label Feb 23, 2024
@megian megian force-pushed the remove-keycloak-jdk-use-container-support branch from ed47893 to 44776bf Compare March 4, 2024 12:24
Copy link

github-actions bot commented May 4, 2024

This pull request has been marked as stale because it has been open for 30 days with no activity. It will be automatically closed in 10 days if no further activity occurs.

@github-actions github-actions bot added the Stale label May 4, 2024
@megian
Copy link
Contributor Author

megian commented May 6, 2024

reactivate

@github-actions github-actions bot removed the Stale label May 7, 2024
@megian
Copy link
Contributor Author

megian commented Jul 1, 2024

@pascal-sochacki Might you be able to review + merge this?

@megian megian force-pushed the remove-keycloak-jdk-use-container-support branch from 44776bf to f7cf2fd Compare July 1, 2024 17:05
The parameter `-XX:+UseContainerSupport` is no longer required for Keycloak >= v21 based on JDK v17.
JDK >= v17 has enabled the container support by default.

Signed-off-by: Gabriel Mainberger <[email protected]>
@megian megian force-pushed the remove-keycloak-jdk-use-container-support branch from f7cf2fd to 2bdf019 Compare July 1, 2024 17:06
@pascal-sochacki pascal-sochacki merged commit 1ea4e3c into codecentric:master Jul 2, 2024
3 checks passed
@megian megian deleted the remove-keycloak-jdk-use-container-support branch July 3, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants