-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add channel for Rubocop 1.24.1 #308
Comments
You can base it on channel/beta after #309 is merged (update: it's merged). You can use the "beta" channel to keep up to date with the latest rubocop. |
Thanks @BrianHawley but we want Code Climate to run the same version of Rubocop as we have in our project's I'd much prefer it if we could bump the version in our Since your change in #309 is merged, are there any blockers you know of to creating the channel? |
@dgholz I can't create channels, so that's one. There's also a rubocop-rails bug fix release that the PR didn't include, though that only affects fixing rather than checking, which would require another PR. Another is that 1.25.0 is out today, so I'm going to make a new PR to update beta (#310), which will also include that rubocop-rails update. In general though, creating new channels currently requires updates to the codeclimate CLI tool, while updating the beta channel doesn't require CLI updates. It would be possible, with a lot of work, to refactor the codeclimate tools so they don't need updates to support new rubocop channels. However, noone (not even me) has allocated the time to do that work. I have been using the beta channel to keep up, until that changes. |
@BrianHawley thanks, could you get someone who can create channels to unblock your PR? I see that Rubocop have released |
@BrianHawley Is there any documentation regarding the https://docs.codeclimate.com/docs/rubocop#using-rubocops-newer-versions Clicking the |
Hi, we'd like to update the version of Rubocop we install to match the latest available version (
1.24.1
). I don't see a matchingchannel
branch on this repo, nor a matching engine in https://github.com/codeclimate/codeclimate/blob/master/config/engines.yml#L197. Please add support for version1.24.1
of Rubocop.The text was updated successfully, but these errors were encountered: