-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rubocop to 1.69.2 #374
base: channel/beta
Are you sure you want to change the base?
Update rubocop to 1.69.2 #374
Conversation
BrianHawley
commented
Nov 9, 2024
- General bundle update.
- Update the docs too.
- Fix rubocop API deprecations.
- Fix reasonable rubocop complaints.
- Disable unnecessary rubocop complaints.
- Explicit ostruct dependency for future compatibility.
- Remove an unnecessary empty file.
@f-moya could you merge this one? It's has a bundle update and rake docs:scrape, but it also fixes the rubocop failures in the code itself, and all of the new rubocop API deprecation warnings in the new version. |
Hi @BrianHawley, I hope you're doing well. I am no longer with Code Climate, so I won't be able to assist with the deployments moving forward. |
@f-moya do you know whose job it is at Code Climate to review and merge these PRs? So I can tag them when I make these updates. |
ccdb63d
to
14138bd
Compare
14138bd
to
722c7df
Compare
Getting this released would be a big help to me. I'm using ruby-lsp and Neovim and it sounds like this should fix the issue according to: Shopify/ruby-lsp#2840 (comment) |
@BrianHawley |
@gfguthrie I checked with the standard people and they were pretty clear that they have no intention to keep their development in sync with that of rubocop, as it's (understandably) too much work. So if it's temporarily in sync, we can't assume that this will continue. It would be a bad precedent to add standard back to the regular rubocop channel when we'd need to remove it again in the near future, when they get out of sync again. It still is the best approach to have a separate set of standard channels, with a separate standard beta channel that would have the latest standard and the latest rubocop that standard supports. As I mentioned before in #357. |
- General bundle update. - Update the docs too. - Fix rubocop API deprecations. - Fix reasonable rubocop complaints. - Disable unnecessary rubocop complaints. - Explicit ostruct dependency for future compatibility. - Remove an unnecessary empty file.
722c7df
to
4db4ad8
Compare