Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bun as package manager #1460

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 24 additions & 18 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,20 @@ jobs:
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/setup-node@v3
# - uses: actions/setup-node@v3
# with:
# node-version: '18'
# cache: 'npm'

- uses: oven-sh/setup-bun@v1
with:
node-version: '18'
cache: 'npm'
bun-version: 1.0.x
no-cache: true

- run: npm ci --prefer-offline --ignore-scripts --no-audit --no-fund
- run: bun install
# - run: npm ci --prefer-offline --ignore-scripts --no-audit --no-fund

- id: compute_percy_enable_for_branch
run: echo "::set-output name=percy_enable::true"
Expand All @@ -42,12 +48,12 @@ jobs:
run: echo "::set-output name=percy_enable::true"
if: steps.compute_percy_enable_for_branch.outputs.percy_enable == 'true' || steps.compute_percy_enable_for_commit.outputs.percy_enable == 'true'

- run: npx ember --version
- run: npx percy --version
- run: bun run ember --version
- run: bun run percy --version

- run: npm run tailwind:build
- run: bun run tailwind:build

- run: npx percy exec --quiet -- npx ember exam --silent --reporter=xunit --parallel=16 --load-balance --preserve-test-name | tee test-results.xml
- run: bun run percy exec --quiet -- bun run ember exam --silent --reporter=xunit --parallel=16 --load-balance --preserve-test-name | tee test-results.xml >/dev/null 2>&1
env:
COVERAGE: true
PERCY_ENABLE: ${{steps.compute_percy_enable.outputs.percy_enable || '0'}}
Expand All @@ -62,8 +68,8 @@ jobs:
fail_ci_if_error: true
token: ${{ secrets.CODECOV_TOKEN }}

- name: Remove percy logs
run: sed -i '/^\[percy\]/d' test-results.xml
# - name: Remove percy logs
# run: sed -i '/^\[percy\]/d' test-results.xml

- name: Remove sentry-webpack-plugin logs
run: sed -i '/^\[sentry-webpack-plugin\]/d' test-results.xml
Expand Down Expand Up @@ -102,13 +108,13 @@ jobs:
# runs-on: ${{ github.actor == 'dependabot[bot]' && 'namespace-profile-frontend-light' || 'namespace-profile-frontend' }}

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/setup-node@v3
- uses: oven-sh/setup-bun@v1
with:
node-version: '18'
cache: 'npm'
bun-version: 1.0.x
no-cache: true

- run: npm ci --prefer-offline --ignore-scripts --no-audit --no-fund
- run: npm run tailwind:build
- run: npm run lint
- run: bun install
- run: bun run tailwind:build
- run: bun run lint
3 changes: 2 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"eslint.validate": [
"glimmer-ts",
"glimmer-js"
]
],
"npm.packageManager": "bun"
}
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ refresh_course_fixtures:
gsed -i '1s/^/export default /' mirage/course-fixtures/*.js

serve:
npm run start
bun run start
Binary file added bun.lockb
Binary file not shown.
Loading
Loading