Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] generate navbar dynamically #118

Merged
merged 15 commits into from
Oct 20, 2020

Conversation

negarjf
Copy link
Contributor

@negarjf negarjf commented Oct 17, 2020

Title

generate navbar dynamically

Related to Issue #114

Number of files/folder added

1 folder and 3 files

- assets [folder]
-- scripts [folder]
--- templates.js
--- app.js
boilerplate.template

Changes made

  • Generate navbar dropdowns using tools.js and categories.js using the Template class
  • Create a boilerplate.template as boilerplate for HTML files of the tools that have all the necessary scripts and markups.
  • update README and CONTRIBUTING files

I have:

  • Read contibuting.md
  • Followed all the guidelines
  • Linked my tool to the index.html file
  • updated readme.md

@negarjf negarjf marked this pull request as ready for review October 20, 2020 15:00
@negarjf
Copy link
Contributor Author

negarjf commented Oct 20, 2020

@shubham2704 This PR is updated and ready to be merged.

@shubham2704 shubham2704 merged commit 60f6bac into codeezzi:main Oct 20, 2020
@shubham2704
Copy link
Member

@shubham2704 This PR is updated and ready to be merged.

@negarjf We tried to add dynamic navbar to other pages, but the navbar doesn't gets generated on other pages, it only worked on index.html page. can you please look into it and find the problem or fix it. ✌

@shubham2704
Copy link
Member

@negarjf Try to reply ASAP.

@negarjf
Copy link
Contributor Author

negarjf commented Oct 22, 2020

@shubham2704 Could you please show me the branch/commit that you tried to use the Navbar? I have tested the navbar on new pages before making the PR and it was working.

@shubham2704
Copy link
Member

  • @negarjf i tried on main branch on commit 4c5e038
  • yes it was working when i merged your PR but the PR's that got merged after yours must have made some changes.
  • i tried to find the problem, but couldn't

The problem on other pages is that it's generating the navbar but not generating the tools under the categories (Basically the dropdown menu for each category is not being generated.)

@shubham2704
Copy link
Member

@negarjf can you fix this bug?

@negarjf
Copy link
Contributor Author

negarjf commented Oct 23, 2020 via email

@shubham2704
Copy link
Member

Sorry for my delay. I will take care of it by the end of today (Central European Time).

On Fri, Oct 23, 2020, 1:27 PM Shubham Goswami @.***> wrote: @negarjf https://github.com/negarjf can you fix this bug? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#118 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6OQKI6DCXGFHEJUR5V4SLSMFSDDANCNFSM4SUUAUKQ .

thank you for helping us ✌. whenever you make the pull request also tell us what was the bug, will be helpful in future.

@negarjf negarjf mentioned this pull request Oct 24, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants