-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] generate navbar dynamically #118
[Feature] generate navbar dynamically #118
Conversation
Update frok from head repo
…y scripts and elements
…te-navbar-dynamically
This reverts commit fe26108.
@shubham2704 This PR is updated and ready to be merged. |
@negarjf We tried to add dynamic navbar to other pages, but the navbar doesn't gets generated on other pages, it only worked on index.html page. can you please look into it and find the problem or fix it. ✌ |
@negarjf Try to reply ASAP. |
@shubham2704 Could you please show me the branch/commit that you tried to use the Navbar? I have tested the navbar on new pages before making the PR and it was working. |
The problem on other pages is that it's generating the navbar but not generating the tools under the categories (Basically the dropdown menu for each category is not being generated.) |
@negarjf can you fix this bug? |
Sorry for my delay. I will take care of it by the end of today (Central
European Time).
…On Fri, Oct 23, 2020, 1:27 PM Shubham Goswami ***@***.***> wrote:
@negarjf <https://github.com/negarjf> can you fix this bug?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#118 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF6OQKI6DCXGFHEJUR5V4SLSMFSDDANCNFSM4SUUAUKQ>
.
|
thank you for helping us ✌. whenever you make the pull request also tell us what was the bug, will be helpful in future. |
Title
generate navbar dynamically
Related to Issue #114
Number of files/folder added
1 folder and 3 files
Changes made
tools.js
andcategories.js
using the Template classboilerplate.template
as boilerplate for HTML files of the tools that have all the necessary scripts and markups.I have: