Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unfinished-Logan-lab-08 #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
**/node_modules/*
**/vendor/*
**/*.min.js
**/coverage/*
**/build/*
21 changes: 21 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"rules": {
"no-console": "off",
"indent": [ "error", 2 ],
"quotes": [ "error", "single" ],
"semi": ["error", "always"],
"linebreak-style": [ "error", "unix" ]
},
"env": {
"es6": true,
"node": true,
"mocha": true,
"jasmine": true
},
"ecmaFeatures": {
"modules": true,
"experimentalObjectRestSpread": true,
"impliedStrict": true
},
"extends": "eslint:recommended"
}
136 changes: 136 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,136 @@
# Created by https://www.gitignore.io/api/osx,vim,node,macos,windows

### macOS ###
*.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon

# Thumbnails
._*

# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent

# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
.apdisk

### Node ###
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Bower dependency directory (https://bower.io/)
bower_components

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules/
jspm_packages/

# Typescript v1 declaration files
typings/

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity

# dotenv environment variables file
.env


### OSX ###

# Icon must end with two \r

# Thumbnails

# Files that might appear in the root of a volume

# Directories potentially created on remote AFP share

### Vim ###
# swap
[._]*.s[a-v][a-z]
[._]*.sw[a-p]
[._]s[a-v][a-z]
[._]sw[a-p]
# session
Session.vim
# temporary
.netrwhist
*~
# auto-generated tag files
tags

### Windows ###
# Windows thumbnail cache files
Thumbs.db
ehthumbs.db
ehthumbs_vista.db

# Folder config file
Desktop.ini

# Recycle Bin used on file shares
$RECYCLE.BIN/

# Windows Installer files
*.cab
*.msi
*.msm
*.msp

# Windows shortcuts
*.lnk

# End of https://www.gitignore.io/api/osx,vim,node,macos,windows
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,6 @@

## Bonus
* **2pts:** a `GET` request to `/api/simple-resource-name` with no **?id=** should return an array of all of the ids for that resource

## Questions and Observations
###### I spent a very long time looking for a bug that didn't really exist, it turns out that I never actually passed my router into my http createserver and I spent hours upon hours trying to fix things that weren't even broken. Once I figured that out in class the rest of the assignment was rather easy, adding the delete and put methods was fairly straight forward.
30 changes: 30 additions & 0 deletions lib/parse-json.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
'use strict';

module.exports = (req) => {
return new Promise((resolve, reject) => {
if(req.method === 'POST' || req.method === 'PUT'){
let body = '';

req.on('data', (data) => {
body += data.toString();
});

req.on('end', () => {
try{
req.body = JSON.parse(body);
resolve(req);
}catch(err){
console.error(err);
reject(err);
}
});

req.on('error', (err) => {
console.error(err);
reject(err);
});
return;
}
resolve();
});
};
10 changes: 10 additions & 0 deletions lib/parse-url.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
'use strict';

const parseUrl = require('url').parse;
const parseQuery = require('querystring').parse;

module.exports = (req) => {
req.url = parseUrl(req.url);
req.url.query = parseQuery(req.url.query);
return Promise.resolve(req);
};
58 changes: 58 additions & 0 deletions lib/router.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
'use strict';

const parseUrl = require('./parse-url.js');
const parseJSON = require('./parse-json.js');

const Router = module.exports = function(){
this.routes = {
GET: {},
POST: {},
PUT: {},
DELETE: {}
};
};

Router.prototype.get = function(endpoint, callback){
this.routes.GET[endpoint] = callback;
};

Router.prototype.post = function(endpoint, callback){
this.routes.POST[endpoint] = callback;
};

Router.prototype.put = function(endpoint, callback){
this.routes.PUT[endpoint] = callback;
};

Router.prototype.delete = function(endpoint, callback){
this.routes.DELETE[endpoint] = callback;
};

Router.prototype.route = function(){
return(req, res) => {
Promise.all([
parseUrl(req),
parseJSON(req)
])
.then(() => {
if(typeof this.routes[req.method][req.url.pathname] === 'function'){
this.routes[req.method][req.url.pathname](req, res);
return;
}
console.error('route not found');
res.writeHead(404, {
'Content-Type': 'text/plain'
});
res.write('route not found');
res.end();
})
.catch((err) => {
console.error(err);
res.writeHead(400, {
'Content-Type': 'text/plain'
});
res.write('bad request');
res.end();
});
};
};
54 changes: 54 additions & 0 deletions lib/storage.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
'use strict';

const storage = {};

module.exports = exports = {};

exports.createItem = (schemaName, item) => {
if(!schemaName) return Promise.reject(new Error('expected schemaName'));
if(!item) return Promise.reject(new Error('expected item'));
if(!storage[schemaName]) storage[schemaName] = {};

storage[schemaName][item.id] = item;

return Promise.resolve(item);
};

exports.fetchItem = (schemaName, id) => {
return new Promise((resolve, reject) => {
if(!schemaName) return reject(new Error('expected schemaName'));
if(!id) return reject(new Error('expected id'));

var schema = storage[schemaName];
if(!schema) return reject(new Error('scheme not found'));

var item = schema[id];
if(!item) return reject(new Error('item not found'));

resolve(item);
});
};

exports.removeItem = (schemaName, id) => {
if(!schemaName) return Promise.reject(new Error('no schemaName given'));
if(!id) return Promise.reject(new Error('no id given'));

let storeSchema = storage[schemaName];
if(!storeSchema) return Promise.reject(new Error('no item found'));

delete storeSchema.id;
return Promise.resolve();
};

exports.updateItem = (schemaName, id, content) => {
if(!schemaName) return Promise.reject(new Error('no schemaName given'));
if(!id) return Promise.reject(new Error('no id given'));
if(!content) return Promise.reject(new Error('no content given'));

let storeSchema = storage[schemaName];
if(!storeSchema) return Promise.reject(new Error('no item found'));

storeSchema.name = content.name;
storeSchema.content = content.content;
return Promise.resolve(storeSchema);
};
12 changes: 12 additions & 0 deletions model/note.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
'use strict';

const uuidv4 = require('uuid/v4');

module.exports = function(name, content){
if(!name) throw new Error('expected name');
if(!content) throw new Error('expected content');

this.id = uuidv4();
this.name = name;
this.content = content;
};
32 changes: 32 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"name": "08-vanilla_rest_api",
"version": "1.0.0",
"description": "![cf](https://i.imgur.com/7v5ASc8.png) Lab 08: Vanilla REST API ======",
"main": "server.js",
"directories": {
"test": "test"
},
"scripts": {
"test": "mocha",
"start": "node server.js"
},
"repository": {
"type": "git",
"url": "git+https://github.com/loganabsher/08-vanilla_rest_api.git"
},
"keywords": [],
"author": "",
"license": "ISC",
"bugs": {
"url": "https://github.com/loganabsher/08-vanilla_rest_api/issues"
},
"homepage": "https://github.com/loganabsher/08-vanilla_rest_api#readme",
"dependencies": {
"uuid": "^3.1.0"
},
"devDependencies": {
"chai": "^4.1.0",
"mocha": "^3.4.2",
"superagent": "^3.5.2"
}
}
Loading