Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYST-661 Implement Form 502 xml pdf other contributions balance #4997

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

tahsinaislam
Copy link
Contributor

@tahsinaislam tahsinaislam commented Nov 18, 2024

Link to pivotal/JIRA issue

https://codeforamerica.atlassian.net/browse/FYST-661

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Implemented tax line 39, 42, 44, 45, 46, 48 and 50
  • Added these lines to the xml and pdfs

How to test?

  • Added unit tests for the MD502 calculator, xml and pdf and the EL101 PDF

Screenshots (for visual changes)

Screenshot 2024-11-19 at 11 58 45 AM Screenshot 2024-11-19 at 11 58 16 AM Screenshot 2024-11-19 at 11 58 04 AM

Copy link

Heroku app: https://gyr-review-app-4997-015efa848390.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4997 (optionally add --tail)

@tahsinaislam tahsinaislam force-pushed the FYST-661-implement-form-502-xml-pdf-other-contributions-balance branch from 48ae764 to 4baf129 Compare November 19, 2024 17:34
@tahsinaislam tahsinaislam changed the title Fyst 661 implement form 502 xml pdf other contributions balance FYST-661 Implement Form 502 xml pdf other contributions balance Nov 19, 2024
@tahsinaislam tahsinaislam marked this pull request as ready for review November 19, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants