Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FYST-902] Add az 1099r to final review #5639

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

squanto
Copy link
Contributor

@squanto squanto commented Feb 25, 2025

Link to pivotal/JIRA issue

https://codeforamerica.atlassian.net/browse/FYST-902

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Add az 1099r to final az review screen

How to test?

  • Navigate through an az return to final review page

Screenshots (for visual changes)

Screenshot 2025-02-25 at 12 15 54 PM

Copy link

Heroku app: https://gyr-review-app-5639-411eafa06a67.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5639 (optionally add --tail)

Copy link
Contributor

@arinchoi03 arinchoi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments, also noticing the screenshot you posted is a slightly off from the figma in the story (the bullet point should be further indented)

Also looks like tests failed!

Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
@squanto squanto force-pushed the FYST-902-az-add-1099-r-sub-to-final-review branch from f0c78be to 13d1e64 Compare February 28, 2025 17:56
@squanto squanto requested a review from arinchoi03 February 28, 2025 18:05
Co-authored-by: Hugo Melo <[email protected]>
@squanto
Copy link
Contributor Author

squanto commented Feb 28, 2025

updated list ui:

Screenshot 2025-02-28 at 1 08 42 PM


<% if Flipper.enabled?(:show_retirement_ui) %>
<%= render "state_file/questions/shared/#{current_state_code}_retirement_income_deductions_review_header" rescue nil %>
<% end %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! i'm glad this worked ✨

none_apply: None apply
subtitle: These allow people to deduct all or a portion of their retirement income from their taxes.
title: Arizona retirement income deductions
uniformed_services: Retired or retainer pay of the uniformed services of the United States
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we check with product about the spanish translations? my guess is that they may have them & just haven't linked it to the story.

Copy link
Contributor

@arinchoi03 arinchoi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants