-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FYST-902] Add az 1099r to final review #5639
base: main
Are you sure you want to change the base?
Conversation
Heroku app: https://gyr-review-app-5639-411eafa06a67.herokuapp.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple comments, also noticing the screenshot you posted is a slightly off from the figma in the story (the bullet point should be further indented)
Also looks like tests failed!
...views/state_file/questions/az_review/_az_retirement_income_deductions_review_header.html.erb
Outdated
Show resolved
Hide resolved
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
f0c78be
to
13d1e64
Compare
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
|
||
<% if Flipper.enabled?(:show_retirement_ui) %> | ||
<%= render "state_file/questions/shared/#{current_state_code}_retirement_income_deductions_review_header" rescue nil %> | ||
<% end %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay! i'm glad this worked ✨
none_apply: None apply | ||
subtitle: These allow people to deduct all or a portion of their retirement income from their taxes. | ||
title: Arizona retirement income deductions | ||
uniformed_services: Retired or retainer pay of the uniformed services of the United States |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we check with product about the spanish translations? my guess is that they may have them & just haven't linked it to the story.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/FYST-902
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
Screenshots (for visual changes)