Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

294 increase box 14 limit #5646

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

294 increase box 14 limit #5646

wants to merge 2 commits into from

Conversation

aloverso
Copy link
Contributor

@aloverso aloverso commented Feb 26, 2025 •
edited
Loading

Link to pivotal/JIRA issue

https://github.com/newjersey/affordability-pm/issues/294

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

What was done?

  • Increase box 14 UI/WF/SWF limit to $180
  • Refactor tests to extract magic numbers (FOR CODE REVIEWERS - note there are two commits here, one for the actual story and one for refactoring with constants. I was a little back and forth on this approach but ultimately I think I like it. Easy to revert (or review separately) if you have thoughts)

How to test?

Visit income editing W2 screen

Screenshots (for visual changes)

image

@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-5646-136341ab1c06.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5646 (optionally add --tail)

mluedke2
mluedke2 reviewed Feb 26, 2025
View reviewed changes
spec/support/helpers/nj_test_const_helper.rb
UI_WF_SWF_ABOVE_LIMIT = UI_WF_SWF_AT_LIMIT + 0.01
FLI_AT_LIMIT = 145.26
FLI_ABOVE_LIMIT = FLI_AT_LIMIT + 0.01
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i really like this refactor!

powersurge360
powersurge360 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@powersurge360 powersurge360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mluedke2 mluedke2 mluedke2 approved these changes

@powersurge360 powersurge360 powersurge360 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aloverso @mluedke2 @powersurge360