Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FYST-1881] Make html consistent between az and id review of 1099 r subtractions #5660

Open
wants to merge 4 commits into
base: FYST-902-az-add-1099-r-sub-to-final-review
Choose a base branch
from

Conversation

arinchoi03
Copy link
Contributor

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Moved the html for id retirement card from id_review to review_header to be consistent with az approach. I think it's in the Income Details section of the review, so feels like it should be in the same area.

How to test?

  • Describe the testing approach taken to verify the changes, including:
    • Tests should still pass
  • Specify any relevant testing environments used (e.g., development, staging, demo, Heroku).
  • Use pangolin (must answer disabled: yes), potato_mfj who have eligible 1099Rs

Screenshots (for visual changes)

looks the same
Screenshot 2025-02-28 at 11 05 18 AM

Copy link

Heroku app: https://gyr-review-app-5660-0e48525e7c0c.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5660 (optionally add --tail)

Copy link
Contributor

@squanto squanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arinchoi03 arinchoi03 marked this pull request as ready for review February 28, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants