FYST-1880 Add recipients address to 1099R #5663
Open
+58
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5663-5c6c4cc7356a.herokuapp.com/ |
arinchoi03
approved these changes
Mar 1, 2025
| @@ -23,6 +23,15 @@ def document | |||
| xml.PayerEIN form1099r.payer_identification_number | |||
| xml.RecipientSSN sanitize_for_xml(form1099r.recipient_ssn) if form1099r.recipient_ssn.present? | |||
| xml.RecipientNm sanitize_for_xml(form1099r.recipient_name) if form1099r.recipient_name.present? | |||
| if form1099r.recipient_address_line1.present? | |||
| xml.RecipientUSAddress do | |||
| xml.AddressLine1Txt sanitize_for_xml(form1099r.recipient_address_line1) if form1099r.recipient_address_line1.present? | |||
There was a problem hiding this comment.
this .present? check seems redundant b/c it's already on line 26
| @@ -23,6 +23,15 @@ def document | |||
| xml.PayerEIN form1099r.payer_identification_number | |||
| xml.RecipientSSN sanitize_for_xml(form1099r.recipient_ssn) if form1099r.recipient_ssn.present? | |||
| xml.RecipientNm sanitize_for_xml(form1099r.recipient_name) if form1099r.recipient_name.present? | |||
| if form1099r.recipient_address_line1.present? | |||
There was a problem hiding this comment.
I wonder about this check -- is it possible that line 1 will be empty but rest of the address present?
Do we only want to pass on the info if the line 1 is present?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
state_file1099_rHow to test?
Screenshots (for visual changes)