Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress warnings in iframe #659

Merged
merged 3 commits into from
Feb 4, 2025
Merged

fix: suppress warnings in iframe #659

merged 3 commits into from
Feb 4, 2025

Conversation

takahashim
Copy link
Collaborator

🎩 What? Why?

#658 のやり直しです。

tiptapが以下のような警告を出してきてるので対応します。

[tiptap warn]: BREAKING CHANGE: "defaultOptions" is deprecated. Please use "addOptions" instead.

テストのエラー避けにCapybara.raise_server_errorsの修正もcherry-pickしています。
またテストでのCSPの上書きにも対応しています。

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG upgrade notes, if required
  • If there's a new public field, add it to GraphQL API
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

@takahashim takahashim marked this pull request as ready for review February 4, 2025 08:41
@ayuki-joto ayuki-joto merged commit c6763ef into main Feb 4, 2025
2 checks passed
@takahashim takahashim deleted the fix-iframe-2 branch February 5, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants