Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: frequency of month #159

Merged
merged 4 commits into from
Mar 20, 2024
Merged

feat: frequency of month #159

merged 4 commits into from
Mar 20, 2024

Conversation

ddevsr
Copy link
Contributor

@ddevsr ddevsr commented Mar 19, 2024

Description
Added frequency everyMonth and betweenMonths.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

lonnieezell
lonnieezell reviewed Mar 19, 2024
View reviewed changes
docs/basic-usage.md Outdated Show resolved Hide resolved
lonnieezell
lonnieezell approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@coveralls
Copy link

coveralls commented Mar 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8353720123

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 75.676%
Totals Coverage Status
Change from base Build 8353580267: 0.2%
Covered Lines: 336
Relevant Lines: 444
💛 - Coveralls

@kenjis kenjis added the enhancement New feature or request label Mar 20, 2024
@lonnieezell lonnieezell merged commit 7ca395d into codeigniter4:develop Mar 20, 2024
31 of 32 checks passed
@ddevsr ddevsr deleted the freq-month branch March 20, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddevsr @coveralls @lonnieezell @kenjis